Mary Morrison #79
Open
Mary Morrison #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rapper.rb to lib, and created test file for it under test/lib/edamam_api_wrapper_test.rb, started self.listrecipes class method, url successfully returns search with app_id and app_key in postman
…esheets/css with contents app.css, foundation.css, and foundation.min.css, bundle installed
…d lib/recipe.rb, embellished listrecipes class method in lib/edamam_api_wrapper.rb
…name/label info, now working on getting everything else.
…class method listrecipes()
…r and added Minitest::Reporters.use!
… to, is working and giving 10 recipes, but it's giving ALL info instead of just the recipe label/name
…agination gem, added yield option from api to model initialize method, created show page - totally working, woot woot
…st search page, pagination working
…ader and footer of index page
… me to; made controller tests and cleaned up unneccessary lines in controller, so skinny...
…cation.html.erb because semantics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe I met all base requirements. I'd really like some feedback on my testing in particular. While my coverage is good, I noticed that the recipe.rb coverage was 100% before I'd finished writing tests, so perhaps it was the way I set up the files? I felt kinda fuzzy on the memoization thingy.
Also, I finally implemented some CSS & Foundation and would love some feedback on that portion. I feel like my application.css file needs some refactoring, but I was really tired when I did it.