Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NYnJA #31

Open
wants to merge 381 commits into
base: master
Choose a base branch
from
Open

NYnJA #31

wants to merge 381 commits into from

Conversation

allisonhoke
Copy link

@allisonhoke allisonhoke commented Oct 28, 2016 •
edited
Loading

  • Excellent teamwork
  • Completed nearly all user stories
  • Test coverage over 90%
  • We did not compensate for a single order that had many merchants for statuses
  • Have unnecessary routes (ex: merchant/:id/products/:id)
  • Git masters
  • This project is wet and fat
  • Need to work out error message display in forms

http://weebay.herokuapp.com/

allisonhoke and others added 30 commits October 24, 2016 11:30
@allisonhoke
added cart method
0277a79
@allisonhoke
adjusted cart view from orderItem to order controller
0cd972f
@allisonhoke
removed validation for email format
c202e95
@allisonhoke
added route for confirmation screen
6c3cda9
@nurlywhirly
Added basic tests to reviews controller.
3bbebba
@allisonhoke
added order routes not using id to be more secure
efd277f
@allisonhoke
adjusting order routes
7efd04a
@allisonhoke
moved controller filter for cart to application controller
fb3104c
@allisonhoke
WIP views for order
62f9d1d
@nurlywhirly
Added tests and some views for category controller
445562d
@nurlywhirly
Finished some reviews controller test logic
618bdbf
@nurlywhirly
Merge branch 'master' of https://github.com/allisonhoke/betsy
e36a188
@allisonhoke
WIP purchase method changes order status, product stock, and clears cart
29f9e5f
@allisonhoke
added link to home on purchase view. adjusted form on update view
f33041b
@allisonhoke
Merge branch 'b/amh/master'
6d32927
@nurlywhirly
Messed with products index action to make browsing by category possible.
a47f7d0
@allisonhoke
updated method call name in purchase method
d22febe
@nurlywhirly
Fixed one lingering review_test.rb test
8bbea95
@nurlywhirly
Merge branch 'nmu/conttesting'
5c044fd
@allisonhoke
removed unnecessary cart route
244d431
@allisonhoke
changed heading
c3f346b
@Ynakashima
products show completed, working on add to cart method in products
4105305
@Ynakashima
Merge branch 'b/yn/products'
8d90609
@allisonhoke
added route to destroy order item (remove from cart)
7321d2d
@allisonhoke
Merge branch 'b/amh/master'
2f4cc5d
@jmojennifer
Added model method to find total revenue; test for method passing; ad…
19f698b 
…ded method call to contorller/instance variable to view
@jmojennifer
Merge branch 'b/jmo/master'
5f78320
@allisonhoke
changed delete to destroy in order item route
867b9d9
@allisonhoke
added link to delete order item and added delete action in controller
e4e64eb
@allisonhoke
Merge branch 'master' of https://github.com/allisonhoke/betsy
7391fed
jmojennifer and others added 27 commits October 28, 2016 11:32
@jmojennifer
Changed layout of order fulfillment tables
5959b1e
@allisonhoke
removed errors from form
56f3e64
@allisonhoke
Merge branch 'master' of https://github.com/allisonhoke/betsy
fb25aa6
@jmojennifer
Added button class to submit link
fe90091
@Ynakashima
products controller testing completed
bbd6426
@Ynakashima
Merge branch 'master' of https://github.com/allisonhoke/betsy
cd66e8d
@Ynakashima
Merge branch 'b/yn/products'
30cd01e
@jmojennifer
Added button styling
c3fa602
@jmojennifer
Merge branch 'master' of https://github.com/allisonhoke/betsy
ce48031
@jmojennifer
Removed duplicate sqlite3 gem reference
fc3a034
@nurlywhirly
Added another application helper test
95b9cdc
@nurlywhirly
Merge branch 'nmu/fixing_things'
ac79881
@allisonhoke
added missing route for ship
b9eb8fd
@allisonhoke
Merge branch 'b/amh/master'
f8c7b18
@allisonhoke
added missing tests to product controller
8130d75
@allisonhoke
added logic to retire product
d8c28da
@allisonhoke
Merge branch 'b/amh/master'
581f2f5
@jmojennifer
Added setting for Heroku images
41871c9
@jmojennifer
Merge branch 'master' of https://github.com/allisonhoke/betsy
a05e83d
@jmojennifer
Added additional setting for Heroku images
912dfb6
@nurlywhirly
Added some more pictures
df67901
@nurlywhirly
Toooootally spelled twister as twitter.
8c188ff
@nurlywhirly
Needed to uniq the categories/products path
611f9e5
@jmojennifer
Added shipping to financials
4ed5725
@jmojennifer
Fixed error per Heroku console
d9bece8
@jmojennifer
Fixed error per Heroku console pt 2
0a44eaa
@jmojennifer
Added shipping to methods
5baeb19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
brackets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@allisonhoke @kariabancroft @nurlywhirly @Ynakashima @jmojennifer