Team Spanx! Noelle, Shari, Yeni and Suzannah #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…set-up a few preliminarty fixtures for testing; and pasted commented text into my review test model file to begin testing customization
…review model file.
…re this out right now--all these tests relate to the quantity validations in the order item model
…wever two of these tests are not yet passing, need to come back to these with FRESH EYES. :)
…wever two of these tests are not yet passing, need to come back to these with FRESH EYES.
…s in the env file
…t all tests now pass. Updated order_item yml file to test for a true and false shipped?
… and put in empty merchant test
…ded validations to Order.
…eated the home_index view. Added login and logout buttons to views.
…troller; WIP sessions controller
…es so that our pages work correctly, due to ordering
…roducts by category
…mit, added logic so that only active products are viewed when looking at products by category.
…ave running at the moment
…tons on the product management view to align with the retire button
…egories and create product and choose as many categories as they want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Webpage: https://footfoot.herokuapp.com/
What we would like you to look at:
Noelle: Please look at the Order Controller (it was one of that last things we touched and is not complete) but we are interested if we were on the right track. Product controller worked, but I would like to know how to test it with login.
Shari: I am not sure if I used session in a logical way. Would it have been better to be attached to an actual Model like Order or OrderItem? Please look.
Suzannah: I look forward to any feedback on my commits.
Yeni: Please look at the login for the session as well as testing on the session for Merchant.
Acknowledge we would like more work on:
All: Testing; this week especially we were working less and less on actual tests(we were at 100% with models last week) (or wrote code that broke old tests). For me (shari!) it was hard to test the cart as I didn’t complete understand session. I am going to try to go back and attempt some. The other models and controllers ended up being modified as we went deeper into the project.
Shari: I forgot to get rid of the OrderItems controller and take out certain Order routes.
Group Dynamics:
We worked extremely well overall.
We took off slowly but we had a good foundation for starting. Overall we also had strong communication. We also freely broke into pair programming and were able to get merge issues easily resolved.
Something to work on, we didn’t touch or go back to the Trello board. Sometimes we had to ask each other what we should work on and the Trello board would have helped.
Where we left off: