Unicorns-'R-US (Brandi, Melissa, Emily, Jessica) #36
Conversation
Creating new merchant/redirecting authenticated merchants
Cartbasics
…arameter should be nickname, not name).
Now able to grab Merchant username
…hash being nil). updated and tested
Validation
improved check in sessions_controller for failed login
edit seems to be working for merchant product
Stylingtiles
Jesschanges
Edited display styling for product show
updated total revenue
added image and title to browser tabs
added default merchant name
|
Group dynamics:
Technical:
Overall I am proud of the work we did. There were aspects that we wanted to implement and ran out of time. But we enjoyed working on the project and it was a pleasant team experience. Go Team Rainbows!! |
|
Reflection Group Dynamics How did the team work together:
Technical
Overall: |
|
How did your team work together? Technical: Overall, I think I can say that I am pretty comfortable at making my vision a reality when it comes to backend, but this is much more painful when it comes to frontend. I think I need to work on being comfortable with HTML & CSS tools so that I can be more efficient with making my vision a reality for design and work through the pain with patience... Overall Part 2: I'm proud of what we accomplished together as a team! It's amazing what you can accomplish in a short amount of time when you're working with so many people, especially those who make it a comfortable working environment, and whose work you trust (in the end I stopped paying too much attention to the file changes pre-merge because I could trust that everyone did good work, and any conflicts we could resolve together). |
Emily's reflection on Betsy/Unicorns-R-UsGroup dynamicsOverall, I felt like our team had a pretty easy time working together. Everyone was very interested in being collaborative and contributing. The only time I felt like it got really stressful was at the very end (when Brandi had her individual meeting during the 15 minutes when we were planning to do our final merge before presentations). Scrambling to do the merge and having some issues with it meant that we were a little off-balance for our presentation. Other than that, from my standpoint, I we didn't encounter any major problems or stress points, and I really enjoyed working with all the members of my team. What helped you stay organized and working together?
What should you have been doing differently?
What would you recommend to C7?
TechnicalWhat went well?I was really happy with being able to come up with the cart on my own. It was not a perfect cart by any stretch of the imagination, though it underwent some improvements after our class conversation to get slightly closer. But it was a technical problem I actually had to think about and write out, which I appreciated and found very satisfying to solve. Overall, I spent the most time working on the cart (user-facing order system), and I feel like it's solid - most of the ways it could break have been addressed, and I think I came up with coherent systems for things like managing stock, dealing with additions, deletions, and updates, etc. What was most challenging?Personally, the thing I found most frustrating was the styling. I definitely didn't leave/allocate enough time for styling, which was likely the root of the problem, but I just have a hard time thinking logically about CSS. When I'm working in Rails or Ruby, I feel like I have all sorts of powers at my fingertips to crack whatever tough nut of a code problem is in front of me. When I'm working in CSS, I feel like these powers disappear, and all I'm doing is making uneducated guesses and hoping something changes. I've improved somewhat in working with basic CSS, but am really not where I should be with Foundation yet. How do you feel about your project overall?I am really proud of my team and what we accomplished. I think the best thing about this project was how well we were able to work together. That said, focusing just on the end product, I think there are some areas of the site that could still be strengthened, built out, or polished. There were a few user stories that just didn't quite make it into the final version, and that would be desirable for a "real" Unicorns 'R' Us site. Also, some parts of the existing site are more thoroughly tested and error-proofed than others. In addition, having seen some of the creative features that classmates came up with for their sites, I think there are a lot of ways Unicorns 'R' Us could be improved and made more polished and professional. I think we decided on a solid but not super ambitious feature set to aim for, and we were able to deliver on that pretty well. However, if I were continuing to work on this project, I would definitely want to add elements such as a database of users (buyers, not just merchants), search, and more polished and advanced CSS styling. |
There was a problem hiding this comment.
@BrandiPhillips @jchung722 @eabrash @olenellina
I've gone ahead and added in-code comments to the bEtsy project. Sorry for taking so long to get back to you on it.
Overall, very very well done. You had good coding style, seemed to gel well as a team and came out with a cute product.
|
|
||
| class CategoryTest < ActiveSupport::TestCase | ||
|
|
||
| test "Categories must have a name" do |
There was a problem hiding this comment.
Probably a better name for this test would be, "Categories can be assigned a name."
| assert categories(:apparel).products.include?(products(:shoes)) | ||
| end | ||
|
|
||
| end |
There was a problem hiding this comment.
There should probably be some validations for Categories, like the name must exist.
You should probably also test that once a product is added to a category it can be found in the .products list.
|
|
||
| validates :orderitems, | ||
| presence: true | ||
|
|
There was a problem hiding this comment.
nice use of the has_scope gem to create filters.
| presence: true, | ||
| uniqueness: true | ||
|
|
||
| def orders (list) |
There was a problem hiding this comment.
Should a merchant have many orders through products.
So you could let Rails do the work for you in this case. Very nice work with the loops however.
| validates :cvv, presence: true, numericality: true, length: {minimum: 3, maximum: 4}, if: :buyer_info_needed? | ||
| validates :billing_zip, presence: true, numericality: true, length: {minimum: 5, maximum: 5}, if: :buyer_info_needed? | ||
| validates :placed_at, presence: true, if: :buyer_info_needed? | ||
|
|
There was a problem hiding this comment.
Very nice use of a custom validator.
| # test "should not get index and instead redirect if user is not a merchant" do | ||
| # session[:user_id] = nil | ||
| # get :index | ||
| # assert_response :success |
There was a problem hiding this comment.
I think that should have been assert_response :redirect
| assert_equal flash[:notice], "Sorry, that product could not be found. Please continue shopping our other awesome products." | ||
| end | ||
|
|
||
| # test "should get new" do |
There was a problem hiding this comment.
What about tests for new products and creating new products?
| def final_total(array) | ||
| total = 0 | ||
|
|
||
| array.each do |item| |
There was a problem hiding this comment.
This belongs in the model as it's doing business logic. View helpers are concerned with display. Minor issue however.
| @@ -0,0 +1,9 @@ | |||
| module ProductsHelper | |||
| @@ -0,0 +1,60 @@ | |||
|
|
|||
There was a problem hiding this comment.
Just a suggestion, but I might add an if to only show the flash notice paragraph tags if they're there. Also if you're using the row for the grid, it's nicer to also include an inside div that specifies the columns, just to deal with possible side effects.
<% if flash[:notice] %>
<div class="row">
<div class="column small-12">
<p> <%= flash[:notice] %></p>
</div>
</div>
<% end %>
@CheezItMan
unicorns-r-us.herokuapp.com