Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

karin/alma/maddie/sky (basketcase) #40

Open
wants to merge 142 commits into
base: master
Choose a base branch
from

Conversation

wordkarin
Copy link

Our app is deployed to heroku at: https://basketcase-betsy.herokuapp.com/
Our trello is: https://trello.com/b/lhhmzqVw/basket-tasks

Things we were proud of:

  1. We were really happy that we decided to do pull requests (got lots of practice and checked each others work). It also made it so that we could understand what each other had worked on, and caught lots of bugs that way.
  2. We took the time to write tests and got 95% coverage!
  3. We were really proud of our "shipped" button (the model and controller interaction too), for merchants. Unfortunately, we were finishing it up right before the presentation and didn't get it merged into master (if you could look at it, it's on our mbj/order_finalization branch).
  4. Routes! We talked about them a lot ahead of time, and we documented what each route was going to do, and didn't have to change them that much. When we nested routes it was clear why it was nested and we didn't have trouble with them too much.
  5. We're proud of our favicon! We forgot to talk about it in our presentation!
  6. We may not have put the authorization in the right place, but we were proud that we got it done - since we kind of added it after we'd built the controllers and views.
  7. Toward the end of the project, we paired on some of the more difficult things, and found it helpful to whiteboard through the issues we were dealing with. For instance, using session to store the order_id for a customer before they'd paid so they could access it, and then deleting it from session when they paid, so they could make another order.
  8. We think we did a good job with model validations, although we had some overly restrictive validations that we had to then remove (e.g. products had to have at least one product_category, but you couldn't create a product_category without a product_id). This also caused us to not be able to reseed our database, and spent a bunch of time trying to figure out what it wasn't working.

Things we would have liked to do:

  1. Those of us who didn't review a specific pull request felt like we didn't know the details of what others were doing.
  2. Our trello board was not very well coordinated with the way we ended up dividing our work, so it was difficult to tell what tasks were able to be picked up next, and we couldn't tell exactly what others were working on. It would have been better than just copying the user stories in to talk through what was necessary for each user story and make tasks based on that.
  3. We did not do a good job writing comments.
  4. We really would have liked to finish the order update (you can currently only add one product to an order (and only one of them)).
  5. We would like to get more practice with branches (we used a lot of branches and didn't know how to delete them or when it was okay to delete).
  6. We ran into lots of issues using the rails app supplied, and thought we had dealt with them, but had lots of git issues with weird files that were auto-generated, and had to completely make a new rails app after over a day of working on it, which ate up a bunch of our time.
  7. We would have liked to have better work/life balance.
  8. Even though we talked about the things we felt comfortable with and needed to work on, we didn't do a great job of dividing up the work so that everyone got to work on a lot of stuff that they wanted to get more experience with (two of us did, two of us didn't).
  9. We would have liked to get the session for our order earlier in the project process, because it turned out to be important for both Maddie and Alma's work, and we didn't start talking about it until we only had two days left.
  10. We did not finish all the tasks; some things we missed: retiring a product, reducing the stock_quantity when an order is paid.

wordkarin and others added 30 commits October 19, 2016 13:49
added product validations and wrote the model tests
Merchant validations implemented through TDD
wordkarin and others added 29 commits October 27, 2016 14:18
* added a new before_action current_order which allows access to the order_id in session

* fixed current_order to session, rather than hardcoded

* paying for an order now deletes session[:order_id]

* removed redundant before_action
* Writing orders#update and the order_items.rb methods, WIP passing tests.

* Passing tests in order_items model. Working on creating new fixtures for these tests

* hooked up add to order button to order/order_item create, fixed bugs
am actually saving order with purchase_time now
* STYLES OMG: index page, updated reviews, merchant show, category show, product cat and category, form styling. 

* added merchant name to show page if logged out

* fixed title on product edit page, saving a purchased order's time
fixed images on merchant page, background on index
* index page styling

* more changes

* css

* updated reviews

* css merchant show

* category show

* css prodcut cat and cat new

* css form styling

* merchant show page

* added merchant name to show page if logged out

* fixed title on product edit page, saving a purchased order's time

* css finessing

* fixed images on merchant prodcut page

* added spacing

* spelling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants