Esther Ng Keyboard #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s only acceptable letters in both cases, added .load to handle pause issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took forever to overhear that it was necessary to use [0] to access something to actually call play() on... not sure how long it would have taken to figure that out on my own, even though I had been staring at the object in the console.
I'm not sure how much of what I was trying to accomplish before had to do with that, and how much had to do with whether I was just taking an approach that would not have worked any way.
At first I thought I was having a scope issue and needed to use a closure but then I didn't end up doing that.
Seems to be functioning as intended on click and on keydown, accounts for handling only those letters with notes and case. Could probably still clean up / refactor further?