Jessica's JS Scrabble #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Nov 21, 2016
| bestWord = word; | ||
| } else if (word.length > bestWord.length && word.length == 7) { | ||
| bestWord = word; | ||
| } |
There was a problem hiding this comment.
I think this series of if/else could be simplified. Think about it a little.
| totalScore += Scrabble.score(word); | ||
| }); | ||
| return totalScore; | ||
| }; |
There was a problem hiding this comment.
Just FYI, the forEach function above is depreciated, but it will still work fine.
| console.log(jess.hasWon()); | ||
| console.log(jess.highestScoringWord()); | ||
| // console.log(jess.highestWordScore()); | ||
|
|
There was a problem hiding this comment.
Good work putting code to test things.
| console.log(Scrabble.highestScoreFrom(["hello", "blah", "test", "elevens"])); //should return "elevens" | ||
| console.log(Scrabble.highestScoreFrom(["hi", "dig"])); //should return "hi" | ||
| console.log(Scrabble.highestScoreFrom(["lost", "tons"])); //should return "lost" | ||
| console.log(Scrabble.highestScoreFrom(["AEIOULD", "QZQZQJ"])); //should return "AEIOULD" | ||
|
|
There was a problem hiding this comment.
You should have a few more tests to test the different possibilities for highestScoreFrom.
Testing in all different orders with:
A 7-letter word
Multiple 7-letter words
Multiple 7-letter words with tied scores.
Word that tie in score
Words that tie in score and are the same length.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@CheezItMan