Beylul Kbreab #25
Open
Beylul Kbreab #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.word = word.split(""); | ||
| var score = 0; | ||
| if (this.word.length == 7) { | ||
| score = 50; |
There was a problem hiding this comment.
I like the way you reassigned the base score based on the length
| } | ||
| } | ||
|
|
||
| for (var i = 0; i < arrayOfWords.length; i++) { |
There was a problem hiding this comment.
This is a bit redundant since it is repeating almost all of the same logic in the loop above. Any ideas on how to consolidate?
| } | ||
|
|
||
| if(scoredWords.length > 1) | ||
| { |
There was a problem hiding this comment.
JS syntax is a bit weird, but we do expect the { to be on the same line as the if and the else
| var totalScore = 0; | ||
| for(var i = 0; i < this.plays.length; i++){ | ||
| totalScore += this.scrabble.score(this.plays[i]); | ||
| console.log(this.scrabble.score(this.plays[i])); |
There was a problem hiding this comment.
This is good for debugging but it results in duplicating the score logic multiple times. I'd recommend assigning this value to a variable and then printing it our for performance purposes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finished with the basic requirements of the project and tested it. I have commented out the tests.