Briana Eng - Scrabble #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ostly calling the other functions incorrectly). Seems to work decently right now, need to check again.
…unctions were called (in both).
CheezItMan
reviewed
Nov 21, 2016
There was a problem hiding this comment.
Overall nice job Briana. I like in particular how you used a Javascript object as essentially a Hash to score words.
I did put a comment here about an overly complicated method. Think about how you can simplify it a bit. I think I remember your Ruby Scrabble being similarly complicated.
| return 'hello world!'; | ||
| var Scrabble = function() { | ||
| this.score = function(word) { | ||
| var cases = {A: 1, E: 1, O: 1, U: 1, L: 1, N: 1, R: 1, S: 1, T: 1, D: 2, G: 2, B: 3, C: 3, M: 3, P: 3, F: 4, H: 4, V: 4, W: 4, Y: 4, K: 5, J: 8, X: 8, Q: 10, Z: 10}; |
There was a problem hiding this comment.
Good use of a JavaScript object as a Hash, exactly as I did it!
| } | ||
|
|
||
| return winningWord; | ||
| }; |
There was a problem hiding this comment.
This seems a little complicated. Couldn't you just use 1 loop with an if statement inside?
| console.log("Should print z - same score, shorter word"); | ||
| var bestWord2 = anotherGame.highestScoreFrom(["z", "kk"]); | ||
| console.log(bestWord2); | ||
|
|
| @@ -0,0 +1,126 @@ | |||
| //WAVE 1 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.