Lauren Brink #31
Open
Lauren Brink #31
+263
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wave 1 complete
…hat that will work better with player module
Wave 2 booyah
…gth but same score
implement Jasmine & some baseline tests for Scrabble
add error handling to wave one, and then tests to go with it
CheezItMan
reviewed
Nov 21, 2016
| totalScore: function(){ | ||
| var total = 0 | ||
| this._plays.forEach(function(play){ | ||
| total += Scrabble.score(play); |
There was a problem hiding this comment.
Just FYI the forEach function is depreciated.
| } else { | ||
| return false | ||
| } | ||
| } |
There was a problem hiding this comment.
Nice use of a regular expression to check to see if it's a valid scrabble word.
| it('scrabble can score a list of words, none of which are bingos, correctly', function() { | ||
| expect(Scrabble.highestScoreFrom(["uuuuuu", "you", "cat", "syzygy" ])).toBe("syzygy"); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Just curious, in terms of Scrabble what's a bingo?
There was a problem hiding this comment.
Bingo is a word that uses all 7 letters or more! Highly recommend this book. https://www.amazon.com/Word-Freak-Heartbreak-Obsession-Competitive/dp/0142002267
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apparently I forked from AdaGold instead of AdaC6, sorry! I hope that doesn't mess things up.