Suzannah #34
Open
Suzannah #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpleting WAVE ONE requirements
… got in a flow. Many of these object properties interacted with others, so I made them somewhat in tandem.
…abble game object, not the testing game object as I coded last night
…en my forEach functions.
| var Scrabble = function() { | ||
| // due to how the specs are written, this score table does not account for the 50 point bonus for 7-letter words... | ||
| this.scoreTable = [ | ||
| [1, "A", "E", "I", "O", "U", "L", "N", "R", "S", "T"], |
There was a problem hiding this comment.
The way this is structured could use JS objects to increase clarity. Using different data at specific indexes can oftentimes be unreliable.
| var scoreTable = this.scoreTable; //this local variable is necessary to bypass the error that otherwise would be thrown in line 18 because the scope of 'this' changes inside anonymous functions. | ||
|
|
||
| if (word.length > 7) { | ||
| return 0; |
There was a problem hiding this comment.
This might also be good to return 0 when the length is zero
| var nonAlphaChar = 0; | ||
| var alphaChars = ["A", "E", "I", "O", "U", "L", "N", "R", "S", "T", "D", "G", "B", "C", "M", "P", "F", "H", "V", "W", "Y", "K", "J", "X", "Q", "Z"]; | ||
|
|
||
| var scoreTable = this.scoreTable; //this local variable is necessary to bypass the error that otherwise would be thrown in line 18 because the scope of 'this' changes inside anonymous functions. |
There was a problem hiding this comment.
The most common way to get beyond this issue is to create a variable called self which is set equal to this. Then, later on when you expect to use this you can use self instead. Sometimes folks also use that or _this, but I personally find both of those sort of confusing.
| // to handle "tie" situations, creating a new array with the words whose score is the greatestVal | ||
| var highestScoreWords = []; | ||
| for (var k = 0; k < arrayOfWords.length; k++) { | ||
| if (this.score(arrayOfWords[k]) === greatestVal) { |
There was a problem hiding this comment.
It would be more efficient to use the scores array here instead of re-calculating the word scores
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By day two (Wednesday), I started enjoying this short project to get more familiar with JS syntax. Last night I was so grateful for console.log helping me "see" that I'd forgotten () and that's why my code wasn't executing how I expected it to.
This project is not DRY, in multiple places!
I've added in functionality to score any words containing one or more non Alpha characters as zero, though in an actual Scrabble game, only Alpha tiles are provided as options. Through adding this optional functionality, I learned that the forEach function behaves differently than a for loop in another way that I didn't expect. While I like being able to 'name' what I'm passing into the forEach function, I might try to use more for loops in the future to avoid confusion. :)