Yasmin - JavaScript Scrabble #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To the question/comment in your PR description, the |
| var word = word.toLowerCase(); | ||
|
|
||
| for (var i = 0; i < word.length; i++) { | ||
| for (var j in scoreChart) { |
There was a problem hiding this comment.
This is one way to do this but pretty inefficient - any ideas on how to optimize?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a hard time getting the hang of scope the variables and functions in Javascript. By messing around with the way the function was defined I was able to call the scoreThisWord function in the Player object (even though it had been defined in the Scrabble object), but I don't know why it works and if that was an acceptable way to do it. Instead of "Scrabble.prototype.scoreThisWord = ", I used "Scrabble.scoreThisWord = ".