forked from AdaGold/tic-tac-toe
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suzannah Kirk-Daligcon #12
Open
sckirk
wants to merge
40
commits into
Ada-C6:master
Choose a base branch
from
sckirk:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as an array. Wrote the code so all tests pass.
…D tests created and passing
…tries to play in a space that's already been played.
…objects for each 'it' test
…s currently full or not. Also made small corrections to other tests, using the beforeEach function syntax to make sure all of our objects are newly instantiated with each test
… pass. Also organized our isDone function.
…me is set as expected in each scenario
…tart button event is functioning. Also corrected the syntax surrounding this restart button event.
…responds to our wave 1 setMark logic. Created an event handler when a square is clicked that saves the value of that square's row and column for future use in wave 3. sweet. exclamation mark.
…rd tests are passing
…player x or o status--set-up necessary prior to converting this JS object into a backbone model
…g set correctly--test passes
…o that tests are passing. I'll still need to insert the logic later that inserts an image onto the gameboard in the browser--wrote a comment to come back to this later
…ile so that all tests pass again
…Exclamation points. Still working on some edge cases in the browser.
…g. Tie game is communicated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rosemary peach tic tac toe with a bamboo background! :) So enjoy these images and the fact that they change for each current player! Yay!!