tic tac karin #18
Open
tic tac karin #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A meaningful pull request!
I was happy to get my backbone app to talk to the API! (It took a little bit of work to get the collection added in after the fact, and get the collection to add the game model using my overwritten toJSON, but it works!)
I did not use templates, and would have liked to go back and add in some underscore templating.
We also kept our board as a 1D array, and I thought about some cool ways to figure out the win logic with a 2D array but did not implement/go back to it. (This week was tough to concentrate.)