Guinevere's tic-tac-toe #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…exports. Created basic Board attributes using BDD.
…ailable and to set a space with the given marker
…djusted test for function
…null board fields be a blank space string instead
…ayers and new game button.
…kbone, with specs.
…e logic lives. Tried and tried and tried to pass the current mark into the tmplate, and need to figure out rendering again.
…events, and played around with a modal. Game logic fully functional on website.
…ndow size. Small windows still problematic.
…and get. Design still lacking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here it is. It was a struggle.
I couldn't figure out how to make my board squares hold their shape without assigning them heights in pixels, which of course broke the Foundation. Ems would shrink with window size, but also introduce extra space between the board columns. I never utilized the possibility of searching for a ready-made tic tac toe board. I think I spent over 4 hours on that one challenge alone.
I would still like to figure out how to delete my model from the database. I couldn't make the delete function work, and I ran into scope issues for 'this' while displaying game data. I used pure jQuery to append the information to my game history element. I even made a delete button with just jQuery, but then I ran into the issue of needing to find the particular game I wanted to delete by id. Perhaps add the particular game's ID to the html p tag somehow, and look it up by that? I would like to look up others' solutions to find out more!
I'm pretty happy with my game logic and tests. I also like that my game history goes away when New Game is clicked, and it updates automatically. Due to my struggles, my design suffered pretty badly. I know I can do better, given more time. Merry Christmas!