Dianne Tic Tac Toe #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd increasing turn count
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finished Waves 1, 2, and 3, but not Wave 4.
The game has a good flow, with a few bugs that I found at the end of the day Friday. Bugs include:
Not showing the "start game over" or "space is taken" messages to players after a new game starts (everything works fine in the first game, but these particular elements never get reset again?)
Appending messages together without clearing out previous messages (ex. when you try to place a marker in an occupied space and have already clicked that same space.). It works when you do not click on the same space after you receive the warning.
Overall, very fun! I will stick to playing tic tac toe on paper though.
P.S. I loved working with Danielle!