forked from AdaGold/tic-tac-toe
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alyssa's Tic-Tac-Toe #34
Open
alyssahursh
wants to merge
94
commits into
Ada-C6:master
Choose a base branch
from
alyssahursh:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…automatically in Game
…Game. Improved description on testing on check winner or tie
Committing to merge fixes from branch alyssa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@CheezItMan
It's not tic-tac-toe; it's SET!
I really, really struggled to understand this project. I beat my head against it for several days and finally gave up. Having nothing to work on once I gave up, I read the entirety of the Backbone.js documentation. Turns out it's fairly short and easy to read. In reading the documentation, it was a lot easier for me to conceptualize a card game than tic-tac-toe. So, I decided to build SET. Commits starting on December 20th reflect this work.
If you're not familiar with SET, the basics are here: http://www.setgame.com/set
In my set game:
Unfortunately, I was not able to rewrite the tests from tic-tac-toe to match the game I wrote. I also did not practice integrating an API into a backbone app.
However, I think that my work is well in-line with the spirit of the assignment, and that I have a much more solid understanding of Backbone than I did before working on this project.
If you'd like to test play the game, it currently console logs a 2-D array with the answers. Each answer is an array of three integers pointing to the placement of the card on the table. The table is zero-based, and counting (unnaturally) goes top-to-bottom, then left-to-right.
Lastly, I'd love to get this up on Heroku. I tried for a while, then my kid brother tried. No dice. All of the commits that just say "test" or "fix" were done by him.