Leah Bueing - unfinished #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Dec 2, 2016
| <script type="text/javascript" src="scripts.js"></script> | ||
| </body> | ||
|
|
||
| </html> |
There was a problem hiding this comment.
More Semantic HTMl should probably be used.
|
|
||
| <script src="js/vendor/jquery.js"></script> | ||
| <script src="js/vendor/foundation.min.js"></script> | ||
| <script src="js/vendor/what-input.js"></script> |
| set: switchInput | ||
| }; | ||
|
|
||
| }()); |
There was a problem hiding this comment.
I'm not quite sure what this file is doing, it looks like letting you detect events on specific keys, mousewheel etc.
| $('body').on('click', 'button', function() { | ||
| console.log('clicked'); | ||
| $.get(url, successCallback); | ||
| }); |
There was a problem hiding this comment.
It would also be good to have a response when the API get request fails.
| $('#category').text(trip.category); | ||
| $('#weeks').text(trip.weeks); | ||
| $('#cost').text('$' + trip.cost); | ||
| }); |
There was a problem hiding this comment.
Nice, it would also be good to do some error-handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am still working on on wave 3, and making trek look nicer. Hopefully I will get a chance to finish soon!