Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queues_Tehut_Getahun_Calculator #32

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Queues_Tehut_Getahun_Calculator #32

wants to merge 2 commits into from

Conversation

tehut
Copy link

@tehut tehut commented Feb 10, 2017

Calculator

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
Describe how you stored user input in your program? I stored user input in variables
How did you determine what operation to perform? I used a series of if statements to compare the variable 'operation' to expected results for each operation and then holding the value of the operation in a new variable
Do you feel like you used consistent indentation throughout your code? Yes
If you had more time, what would you have added to or changed about the program? I would have liked to use case statements and added the optionals

@kariabancroft
Copy link

Calculator

What We're Looking For

Feature Feedback                                                                              
Takes in two numbers and an operator and performs the mathematical operation. Well Done
Baseline
Readable code with consistent indentation. Mostly good, though keep conditions on same line as keywords 'if', 'elsif', etc.
Extras
Functionality I was able to put something that wasn't a number as the second number that went through twice. Looks like it is coming out as 0. Overall, the conditionals look more complicated than the need to be, which can make it more prone to improperly handling error and making it hard to see where that is happening. Variables like have_values and have_operation shouldn't need to be used, could test the actual variable to see if it has a value. Remember nil is equal to falsey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants