Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create kelly_souza_calculator.rb #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kellysouza
Copy link

Calculator

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
Describe how you stored user input in your program? I stored user input into variables.
How did you determine what operation to perform? I user include? to verify if the user input operator is included in an array of possible operators (variations of each operator).
Do you feel like you used consistent indentation throughout your code? yes, I believe so.
If you had more time, what would you have added to or changed about the program? I would have liked to be able to complete a more complex function rather than four individual functions. Also error control would be nice. I got hung up on the parenthesis issue, almost have it worked out.

@kariabancroft
Copy link

Calculator

What We're Looking For

Feature Feedback                                                                              
Takes in two numbers and an operator and performs the mathematical operation. Done, but seems to do it twice...
Baseline
Readable code with consistent indentation. Well Done
Extras
Exponentiation Well done

Summary

It seems like you have two versions of your project here. Also have you figured out how to determine if an input is a valid number?

Nice work using a case statement to determine the operation.

Reviewed by Chris

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants