Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elizabeth Deutsch - Queues - MediaRanker #36

Open
wants to merge 27 commits into
base: master
Choose a base branch
from

Conversation

edeutschie
Copy link

@edeutschie edeutschie commented Apr 17, 2017

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe a custom model method you wrote. In the work model, I wrote a custom method called self.find_spotlight. It counts and compares the votes of all the works in the database and returns the one with the most votes.
Describe how you approached testing that model method. What edge cases did you come up with? I reassigned this to my list of things to go back and do when I had time.
Describe an edge case test you wrote for a controller I reassigned this to my list of things to go back and do when I had time.
What are session and flash? What is the difference between them? Flash sends a one time message when something specified (like logging in successfully), but when the page is refreshed the message does not reload. Session keeps track of something specified (like being logged in for a session or period of time) until that specific thing is no longer true (like when a person logs out).
Describe a controller filter you wrote. I believe this lecture was deferred.
What was one thing that you gained more clarity on through this assignment? I became much more clear on working with different branches on github and also deploying on Heroku. And I got to practice dropping and recreating databases in rails.
What is the Heroku URL of your deployed application https://dry-oasis-19470.herokuapp.com/
Do you have any recommendations on how we could improve this project for the next cohort? It seemed like a big leap in terms of new material that we had to incorporate into this rails project. Adding testing and all the other new elements felt like alot for one week with such a large scale project to complete.

If you need me to break down what to look for in this program that works, let me know.

…ut. missing the piece that actually makes the two execute
@PilgrimMemoirs
Copy link

Media Ranker

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Well Done
Comprehension questions Even if you didn't complete something, write what you would have done
General
Rails fundamentals (RESTful routing, use of named paths) Well Done
Semantic HTML Well Done
Errors are reported to the user Well done
Business logic lives in the models Well Done - gather methods could all be one instead of one for each category
Model testing Good start - need more edge cases and to test custom methods. Would like to see fixtures used more in the future.
Controller testing Well Done
Wave 1 - Media
Splash page shows the three media categories Well Done
Basic CRUD operations on media are present and functional Mostly Good - New not complete
Wave 2 - Users and Votes
Users can log in and log out Well Done
The ID of the current user is stored in the session Well Done
Individual user pages and the user list are present Well Done
A user cannot vote for the same media more than once Not complete
All media lists are ordered by vote count Not Complete
Splash page contains a media spotlight Well Done
Media pages contain lists of voting users Well Done
Wave 3 - Styling
Foundation is used appropriately Added, grid not implemented
Look and feel is similar to the original Not Complete
Overall

Somethings that were not complete in this project that we will be looking for you to work in in bEtsy: Using Foundation's grid, complete CRUD functionality, Model testing, using fixtures and to DRY up models and controllers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants