Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queues #38

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Queues #38

wants to merge 23 commits into from

Conversation

EricaJCasePhD
Copy link

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe a custom model method you wrote. None yet
Describe how you approached testing that model method. What edge cases did you come up with? None
Describe an edge case test you wrote for a controller None
What are session and flash? What is the difference between them? Session stores information in the browser, allowing settings such as username to be stored between sessions. Flash outputs a message that no longer exists when the browser is refreshed. --The difference is flash is transient while flash is persistent.
Describe a controller filter you wrote. I didn't use one.
What was one thing that you gained more clarity on through this assignment? This assignment made me more confused.
What is the Heroku URL of your deployed application https://arcane-fortress-57410.herokuapp.com/
Do you have any recommendations on how we could improve this project for the next cohort?

@PilgrimMemoirs
Copy link

Media Ranker

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Well Done
Comprehension questions Even if you haven't completed the functionality that the question is asking about, describe what you would do - that way we can have a better idea of your comprehension of that question
General
Rails fundamentals (RESTful routing, use of named paths) Well Done
Semantic HTML Sometimes - All content should be organized into semantic tags like , or
Errors are reported to the user Not complete
Business logic lives in the models Not complete
Model testing Some - Use more edge case testing and testing validations
Controller testing
Wave 1 - Media
Splash page shows the three media categories Shows the work but isn't organized visually
Basic CRUD operations on media are present and functional Mostly Good - Can create, read and update but not destroy
Wave 2 - Users and Votes
Users can log in and log out Good start - Login creates a new user every time, even if user with the username already exists
The ID of the current user is stored in the session Well Done
Individual user pages and the user list are present Well Done
A user cannot vote for the same media more than once Not Complete
All media lists are ordered by vote count Not Complete
Splash page contains a media spotlight Not complete
Media pages contain lists of voting users Not Complete
Wave 3 - Styling
Foundation is used appropriately Added, grid not used
Look and feel is similar to the original Not Complete
Overall
There are some things missing that I want to see you work in in Betsy: Model and Controller Tests, Full CRUD operations on a resource, Model Logic, Foundation grid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants