Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queues- Anna Barklund - MediaRanker #42

Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open

Conversation

amb54
Copy link

@amb54 amb54 commented Apr 17, 2017

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe a custom model method you wrote. I wrote a method that sorted the work records according to their vote count, but ended up not using it.
Describe how you approached testing that model method. What edge cases did you come up with? I did not test this method. What I should have done was to test how the method handled the situation with no records. Also if the sorting was done correctly. I did not do well with the test this time around. There were some tests that I did not get to work. Maybe due to that I used sessions in the actions.
Describe an edge case test you wrote for a controller For books movies and albums I checked that the path was responding successfully when there were no records.
What are session and flash? What is the difference between them? session stores data that can be used through different calls. flash does only keep data till it has been "used" once (rendered to the browser)
Describe a controller filter you wrote. I did not use a controller filter.
What was one thing that you gained more clarity on through this assignment? Again the routes is somewhat diffuse for me. But I am getting there : )
What is the Heroku URL of your deployed application https://media-ranker-amb.herokuapp.com/
Do you have any recommendations on how we could improve this project for the next cohort? This project was truly a challenge, but good. The first wave took me three days.

amb54 added 30 commits April 10, 2017 15:36
… models (work, user, vote). Created lib/seeds. Copied media_seeds.csv to this folder. Added code to db/seeds.rb to read in data in the database.
…lationships in the models for work, user and vote. Created tests for validation for model. Added validations to work model. Tests passed
…ontroller. Wrote code for the index method in the welcome controller. Wrote three sections in the welcome index view, one for each table.
…r. Added routes for those in routs. Added a link to the albums view (the action albums uses the controller view) in the welcome view.
…it work : ) . Added has_many-trough to user and work models.
…vies in the work controller. Updated the category view with a table. Updated the index view for works with links to category views.
…ance variables in index for the work controller. Added the links to the show pages for the works in the index view for the works.
… with new/create edit/update and delete. Generated the controller Sessions. Added login logout to routes. Added new/create and delete to the sessions controller. Added new view for sessions with code for a form for user. Added foundation to stylesheet.
…pdated the actions create, albums, books and movies to use sessions for storing the category. Started a method in works ordered_works. Uppdated application view with sections for login/logout and flash. Added the error messages to the _form vieww for works. Updated the category view (for works) to use sessions. Updated the works index view with foundation code. Added routes for album/new book/new and movie/new.
…ods for works. Updated work model with two methods self.ordered_works and self.order_by_votes. Updated edit in works controller. Updated update action in works controller with an if-else to choose redirection path. Rearranged links in the category view. Added vote counts to the works index view. Added foundation code to show view for works. Added new test for works-controller create.
…Added pseudocode for upvote. Added route for upvote. Coded users index view. Updated works index to pass Heroku deployment. Added foundation code to works show index. Changed the code for randomly generate votes in seeds. Got the test for works controller create to work.
…rted by number of votes. Updated works category and show view with links.Updated users index and show views with strftime method for the create date. Added foundation code to users index view. Added code to users show.
… the works views category and show. Changed the link forthe back button in the works show view.
…ated the index view with buttons for adding media and did some rearangement to better accomodate foundation code.
…ry. Made changes related to users index and show.
@PilgrimMemoirs
Copy link

Media Ranker

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Well Done
Comprehension questions Well Done
General
Rails fundamentals (RESTful routing, use of named paths) Well Done
Semantic HTML Well Done
Errors are reported to the user Well done
Business logic lives in the models Mostly good - the logic for getting querying works and ordering them is logic that should be a model method.
Model testing Good start
Controller testing Works controller well done
Wave 1 - Media
Splash page shows the three media categories Well Done
Basic CRUD operations on media are present and functional Well Done
Wave 2 - Users and Votes
Users can log in and log out Well Done
The ID of the current user is stored in the session Well Done
Individual user pages and the user list are present Well Done
A user cannot vote for the same media more than once Well Done
All media lists are ordered by vote count Well Done
Splash page contains a media spotlight Well Done
Media pages contain lists of voting users Well Done
Wave 3 - Styling
Foundation is used appropriately Well Done
Look and feel is similar to the original Well Done
Overall
Would like to see the following things not completed in this project to be worked in during by you during bEtsy model testing, adding logic into model methods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants