Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queues - Sofia Kim - Soloar_System #28

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

Sofia15
Copy link

@Sofia15 Sofia15 commented Feb 15, 2017

Solar System

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
What was the purpose of the initialize method in your class? The purpose for 'initialize' method is to define parameters for a new object we created so I can pass arguments to new method by using 'new'.
Describe an instance variable you used and what you used it for. name, diameter, distance_from _the_sun, orbit_period, human_being_alive are used as instance variables to utilize as description for each planets.
Describe what the difference would be if your SolarSystem used an Array vs a Hash.
Do you feel like you used consistent indentation throughout your code? yes

@PilgrimMemoirs
Copy link

Solar System

What We're Looking For

Feature Feedback
Created Custom Class with initialize method & instance variables. Well Done
Used an Array to store a list of planets in the SolarSystem class. Well Done
Readable code with consistent indentation. Well Done
Created a pull request with your name & a meaningful message. Missing a response on array vs hash question.

Regarding code in wave1.rb: When assigning planets to variables, variables should only start with a lowercase letter. Capitalization is only used on class names. This file was also missing the planet class.

I focused more on assessing the code in wave 2, which all looks great!
In the future, you only need to submit one file with your most recent work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants