Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queues - Kayla Kubicke - Solar System #42

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Queues - Kayla Kubicke - Solar System #42

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 15, 2017

Solar System

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
What was the purpose of the initialize method in your class? The initialize method automatically creates a series of instance variables each object will have. Put another way, when you create an object in a class each object will have the properties listed in the initialize method.
Describe an instance variable you used and what you used it for. I used '@color = color' to describe the color of each planet.
Describe what the difference would be if your SolarSystem used an Array vs a Hash. The array has a specific order, the hash does not.
Do you feel like you used consistent indentation throughout your code? I tried very hard to follow all the style rules outlined in jumpstart live, including indentation.

Request: If any of my comments were inaccurate/incomplete could I receive specific feedback on them? (Just looking for a yay or nay, I can study further. I just want to make sure I understand the concepts.)

Also, based on my understanding, my 'Wave 2' solution is incomplete based on the instructions. I understand that I was suppose to create the attribute 'planet', which I did, but I did not create new Planet class instances. I simply asked the user to create arrays with the planet names which did not reference back to the Planet class. I did work on this solution but I did not get it working in time.

@PilgrimMemoirs
Copy link

PilgrimMemoirs commented Feb 15, 2017

Solar System

What We're Looking For

Feature Feedback
Created Custom Class with initialize method & instance variables. Well Done
Used an Array to store a list of planets in the SolarSystem class. Well Done
Readable code with consistent indentation. Well Done
Created a pull request with your name & a meaningful message. Well Done

Nice addition of making this interactive in terminal. To keep code clean, keep any user input code outside of the class.

Line 21-26 and 36-41 are not necessary. The only array planet objects needed to be added to was the one inside of a solar system.

Solar System should only have one array to store planets, both methods should add to that same array.

Comments on your Comments: The initialize method does that, and more! By more, I mean that it will run any code you put in there, could be calling a few other methods, whatever. And initialize will run all of it when a new instance of the class is made. But you're totally correct in that what you said is the only way we've used it so far :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants