Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Queues - Marisol Lopez - Solar_System.rb #48

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

marisol-lopez
Copy link

Solar System

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
What was the purpose of the initialize method in your class? I used it to store all of my instance variables which allowed me to add values to each of them to be called upon later on.
Describe an instance variable you used and what you used it for. I used one named @name so that I could store the Planet names and that way I could call them from ourside the method I created them in.
Describe what the difference would be if your SolarSystem used an Array vs a Hash. I wanted to use a hash but I ended up using an array. My array would need to call each object by index rather than if I had used a hash which would be by the key name. A hash would be useful because for the purposes of this project; the planet names could've served as the key names since no two names repeat.
Do you feel like you used consistent indentation throughout your code? Yes

@PilgrimMemoirs
Copy link

Solar System

What We're Looking For

Feature Feedback
Created Custom Class with initialize method & instance variables. Well Done
Used an Array to store a list of planets in the SolarSystem class. Well Done
Readable code with consistent indentation. Well Done
Created a pull request with your name & a meaningful message. Well Done

If you're not using any code, like the myplanet method that is outside of the planet class, either remove it or comment it out. Just to keep your code tidy :)

I would like to see your tests, like for solar system. Even if you comment them out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants