-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Queues - Tehut Getahun --Static Site #22
base: master
Are you sure you want to change the base?
Conversation
Static SiteWhat We're Looking For
Great work overall. Site is attractive and easy to navigate, and HTML forms a clear tree structure. I especially like the way you've broken your CSS out into multiple files - that makes it easy to see what affects what. |
margin-top: 10%; | ||
margin-left: 0px | ||
margin-bottom: 30%; | ||
background-image: url('/Users/tehutgetahun/ada/que/week6/hw/Static-Site/assets/photos/market.JPG'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've got an absolute path here, which includes your username! This means that your image won't load on anyone else's machine.
It's always better to use relative paths for this sort of thing. In this case it would be something like assets/photos/market.JPG
(note there's no leading /
)
Great job, Tehut! I like how you explored the fade in animation and google fonts. Looks great! The use of selector here is really nice. It shows a deep grasp of selector concepts. Nice work to make HTML tags semantic. You will find class and ID are even more handy to organize HTML elements in the future. You may also consider to use rem/em instead of px to make your website views more responsive. As to broken link to pictures, you can also hold the pictures on a public server. |
Static Site
Congratulations! You're submitting your assignment!
Comprehension Questions