Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queues - Tehut Getahun --Static Site #22

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

tehut
Copy link

@tehut tehut commented Mar 20, 2017

Static Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? My primary issue was spacing.
Why is it important to consider and use semantic HTML? It creates flexibility and makes our code more readable.
How did you decide to structure your CSS? I used a lot of inline blocs and semantic tags to break up the boxes and use their flow.
What was the most challenging piece of this assignment? I found it easier to control my layout when I wrote my own html, however I did enjoy stretching myself and learning how to modify animations, text shadows and icons.
Describe one area that you gained more clarity on when completing this assignment Why the box model makes sense--thinking of the screen as a series of nested boxes makes so much sense.

@tehut tehut changed the title Queues - Tehut Getahun Queues - Tehut Getahun --Static Site Mar 20, 2017
@droberts-sea
Copy link

Static Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage yes
Answered comprehension questions yes
Page fully loads yes
No broken links (regular or images) None of your images load! Did you remember to git add them?
Includes at least 4 pages and styling yes
HTML
Uses the high-level tags for organization: header, footer, main yes
Appropriately using semantic tags: section, article, etc. yes
All images include alternate text yes
CSS
Using class and ID names in style declarations yes
Style declarations are DRY yes
Overall

Great work overall. Site is attractive and easy to navigate, and HTML forms a clear tree structure. I especially like the way you've broken your CSS out into multiple files - that makes it easy to see what affects what.

margin-top: 10%;
margin-left: 0px
margin-bottom: 30%;
background-image: url('/Users/tehutgetahun/ada/que/week6/hw/Static-Site/assets/photos/market.JPG');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've got an absolute path here, which includes your username! This means that your image won't load on anyone else's machine.

It's always better to use relative paths for this sort of thing. In this case it would be something like assets/photos/market.JPG (note there's no leading /)

@mayawang
Copy link

mayawang commented Apr 6, 2017

Great job, Tehut!

I like how you explored the fade in animation and google fonts. Looks great!

The use of selector here is really nice. It shows a deep grasp of selector concepts. Nice work to make HTML tags semantic. You will find class and ID are even more handy to organize HTML elements in the future. You may also consider to use rem/em instead of px to make your website views more responsive.

As to broken link to pictures, you can also hold the pictures on a public server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants