Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haby's Static Site #31

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 62 additions & 0 deletions about.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<link rel="stylesheet" href="stylesheets/styles.css">
<link rel="stylesheet" href="font-awesome-4.7.0/css/font-awesome.min.css">
<link rel="stylesheet" type="text/css"
href="https://fonts.googleapis.com/css?family=Lobster|Harmattan|Josefin+Sans|Abel|Lato|Playfair+Display">
<title>About Me</title>
</head>

<body id="page3">
<header>
<div class="header-name">
<a href="about.html" target="_blank">Haby Randall</a>
Copy link

@jchung722 jchung722 Apr 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to rethink using target="_blank" for links to pages of your website since it opens pages into a new tab. Makes sense and super useful for the way you used this for your links to social media sites!

</div>
<nav class="top-nav">
<ul>
<li class="btn"> <a href="hobby-blog.html" target="_blank">Hobbies</a></li>
<li class="btn"> <a href="porfolio.html" target="_blank">Porfolio</a></li>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link is broken because portfolio is mispelled

<li class="btn"> <a href="about.html">About Me</a></li>
</ul>
</nav>
</header>

<main>
<section>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

section tags may be unnecessary since page is already divided into articles

<article class="bio">
<img src="images/IMG_4566.JPG" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding a description under an "alt" attribute to image tags can be helpful in case links to images are broken.

<div>
<h2>I'm Haby, a student at Ada Developer's Academy:</h2>
<p><p>Pellentesque habitant motristique senectus et netus et malesuada fames ac turpis egestas. Vestibulum tortor quam, feugiat vitae, ultricies eget, tempor sit amet, ante. Donec eu libero sit amet quam egestas semper. Aenean ultricies mi vitae est. Mauris placerat eleifend leo.</p></p>
<p><p>Pellentesque habitant moristique senectus et netus et malesuada fames ac turpis egestas. Vestibulum tortor quam, feugiat vitae, ultricies eget, tempor sit amet, ante. Donec eu libero sit amet quam egestas semper. Aenean ultricies mi vitae est. Mauris placerat eleifend leo.</p></p>
</div>
</article>
</section>
<section>
<article class="likes">
<h2>Some Things I love:</h2>
<div class="img-container">
<a href="https://www.beaches.com"><img src="images/2.jpeg" /></a>
<a href="http://www.thephotoargus.com/"><img src="images/5.jpeg" /></a>
<a href="http://www.candy.com/"><img src="images/candy.jpeg" /></a>
<a href="http://www.starbucks.com"><img src="images/coffee.jpeg" /></a>
</div>
</article>
</section>
</main>

<footer>
<div class="left">© Copyright 2017 by Haby Randall</div>
<div class="right">
<ul>
<li><a href="https://github.com/habypsow" target="_blank" class="github"><i class="fa fa-github" aria-hidden="true"></i></a></li>
<li><a href="https://www.facebook.com/profile.php?id=12440179" target="_blank" class="facebook"><i class="fa fa-facebook-square" aria-hidden="true"></i></a></li>
<li><a href="https://www.instagram.com/habsr/?hl=en" target="_blank" class="instagram"><i class="fa fa-instagram" aria-hidden="true"></i></a>
</li>
<li><a href="https://twitter.com/" target="_blank" class="twitter"><i class="fa fa-twitter-square" aria-hidden="true"></i></a></li>
</div>
</footer>
</body>
</html>
7 changes: 7 additions & 0 deletions font-awesome-4.7.0/HELP-US-OUT.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
I hope you love Font Awesome. If you've found it useful, please do me a favor and check out my latest project,
Fort Awesome (https://fortawesome.com). It makes it easy to put the perfect icons on your website. Choose from our awesome,
comprehensive icon sets or copy and paste your own.

Please. Check it out.

-Dave Gandy
Loading