Queues - Allison Northrop - Static Site

[Allison-Northrop]

Static Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they?	For some reason the HTML validator had a problem with my google font "merriwether" link. However, on the site it's working and it's what google fonts said to add.
Why is it important to consider and use semantic HTML?	Semantic HTML helps with organization. It helps the developer know where certain content needs to be and it can help in css if id's or classes are needed.
How did you decide to structure your CSS?	I started out with all my css on one page, connected to all html docs. However, this started getting really messy, so I decided to have multiple css documents. I'm honestly not sure if that's best practices, but it worked best for my site.
What was the most challenging piece of this assignment?	For me, the most challenging piece of this assignment was not being able to implement all the design elements I wanted. I got distracting on design and spent too much time obsessing over what looked "good".
Describe one area that you gained more clarity on when completing this assignment	I gained a lot more clarity on how to use css selectors like :hover as well as how to move inline blocks around effectively on a page. I'd like to say I gained more clarity on making my CSS more DRY, but I'm still at the stage where I'm trying a bunch of things until something finally works.

[PilgrimMemoirs]

Static Site

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage	Should commit much more often
Answered comprehension questions	Well Done - Totally okay to have multiple CSS files, it is actually a good practice to have one for each webpage. Especially as you start having a lot of CSS code to deal with. That being said, it's good when there are unique styles to each page - whereas with your pages there are many repeated styles, especially rulesets between all the pages. Those repeated rulesets could be in their own main file that is linked to all the pages. Then each page link to the specific styles in those separate css files. blog.html should have each post in it's own sectioning tag, like .
Page fully loads
No broken links (regular or images)	Images and links were broken - use relative instead of absolute paths
Includes at least 4 pages and styling	Well Done
HTML
Uses the high-level tags for organization: header, footer, main	Mostly Good - Some pages did not use
Appropriately using semantic tags: section, article, etc.	Okay - about.html and blog.html should have some sectioning tag around the and tags. portfolio.html should have included in the div. Div could be a . In index.html, elements in nav do not need their own tags. Sectioning tags in general should have more than one child element.
All images include alternate text	Well Done
CSS
Using class and ID names in style declarations	Mostly Good
Style declarations are DRY	Mostly Good - As mentioned above, repeated rulesets should be in a shared page. The articles in portfolio have a few styles that are being repeated, could be combined into a single ruleset.
Overall
Linking	If you're linking to an image or another HTML page within the project, use the the local path. Otherwise the images will appear broken, as they did on my computer when I cloned the project.

[heatherherrington]

In general: Nice job! I like the design, color scheme, and fonts you chose. I also like how the '@GN' logo has a fixed position. That's a nice level of continuity from page to page. With a few exceptions, you did a nice job with indentation - I know this sounds trivial, but trust me that this will help with debugging later on. Also, some languages (i.e. Python) require appropriate indentation for functionality, so this is a good habit to have right away. I wish you had made your links relative rather than absolute, since I can't just click through and see your site, and none of your images load. Also, while it really isn't necessary for this project, in the future, make sure you comment your code. That will make it much easier for you and other developers to read and debug. And git commit more often. Trust me - when you make a change and break something and cannot figure out what you did, having a recent commit to revert back to is a lifesaver!

CSS:
I noticed that you have "bottom_para" declared in a few files. Try to DRY this up. Nice job having "backup fonts" (cursive, serif), just in case your custom fonts don't load. Rather than explicitly declaring 'margin-left, margin-bottom' etc, maybe just do 'margin' and 'padding' and list all parameters on one line.

Page-by-page:
Index: I like how this page is set off from the rest, with the full-screen colored background and the white background behind your name. It's a nice contrast. I'm not sure that I would have made a nav bar of the 'About, Portfolio, Blog' links - I associate nav bars more with things in the header or footer, that are repeated from page to page. But that's mostly a style thing. Good use of semantic 'section' tags.

About: There's quite a bit of space between your final paragraph and the footer bar. Not sure if this was intentional.

Blog: Overall, I like it. Something you might want to consider if you run with this design for an actual page, though, is how the date published will fit into things. Will that be a part of the blog title? Will it appear at the bottom of each post? Formatting, etc.

Portfolio: Your footer on this page is different from the rest of the pages, with the spacing of the various links. Was this intentional? Overall, though, I like the layout.