Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theresa's Task List #25

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

TheresaManney
Copy link

@TheresaManney TheresaManney commented Mar 26, 2017

Task List

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe in your own words what the Model is doing in Rails The Model uses data from the database and makes sure the data is the correct data type (string / text / etc...), the data is also stored in the Model.
Describe in your own words what the Controller is doing in Rails The controller uses information that is given from the browser and decides what info is needed from the Model or the View
Describe in your own words what the View is doing in Rails The View use what the Controller gives to it and converts it to HTML and then further, CSS is then used to make things look better. The View configurations are what is then returned for the user to see.
What is the purpose of using strong params? (i.e. the params method in the controller) Strong params are used so malicious data cannot be input into the program to ruin the original content. A malicious user might try, but anything they try will be ignored thanks to strong params.
How are Rails migrations related to Rails models? Migrations are new versions of a Model. Migrations allow us to add columns, tables and entries to a schema that is used by the Model to organize the database..From what I understand..
Describe one area of Rails that are still unclear on 1. I have a hard time understanding why I have to go through the whole migration process just to create a new column, I don't completely understand why we can't just make a modification to a migration file and then migrate that new change. Making several migrations seems inefficient to me and does not make sense to me. 2. I noticed that every time I edit an item in my task list, it clears out whatever original due dates and completion date that was set prior to the edit... I have tried several things to try to avoid this but nothing has worked so far. Any suggestions on how I can google this questions would be helpful, or any solutions you can think of? Maybe I have to change a columns data type through a migration? Any help is appreciated!

@CheezItMan
Copy link

Task List

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in Decent number of commits
Answered comprehension questions Migration are changes to the structure of the database, or schema. They change how the data is organized not individual entries (columns, new tables, renaming rows or tables etc).
Successfully handles: Index, Show Nicely done
Successfully handles: New, Create Check, it looks like you tried to use a partial view and gave up. Hopefully you'll be ready on the next project.
Successfully handles: Edit, Update I do notice when I update a task that the due date isn't set. That's probably because it's a string and you would have to convert it to a datetime for the form control to use it.
Successfully handles: Destroy, Task Complete Check
Routes follow RESTful conventions Check
Uses named routes (like _path) Check
Overall Overall nicely done, there's some minor DRYing of your CSS that could be done and the things I noted above. I do like the rollover effect used for viewing & marking a task complete. Well done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants