Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queues - TaskList - Maria McGrew #30

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Queues - TaskList - Maria McGrew #30

wants to merge 11 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 27, 2017

Task List

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe in your own words what the Model is doing in Rails Model is what interacts with the database.
Describe in your own words what the Controller is doing in Rails Takes the request from the user and and tells the View how to render the user's request.
Describe in your own words what the View is doing in Rails It is the code that knows how to present things to the user.
What is the purpose of using strong params? (i.e. the params method in the controller) To prevent people from messing up your stuff so we set parameters to permit certain fields, but dump anything that doesn't meet that criteria.
How are Rails migrations related to Rails models? They create the database entries that create and update/change the table's characteristics such as row and column.
Describe one area of Rails that are still unclear on How the database id is updated after adding/deleting a new task. My table kept incrementing up so after I delete row 22, it wouldn't replace row 22, but instead make a row 23 which would cause an error when it was deleted.

@PilgrimMemoirs
Copy link

Task List

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in Well Done - Could commit more often
Answered comprehension questions Mostly Good - could be more specific, how is the model interacting with the database? The model also handles an application's business logic, if there is any.
Successfully handles: Index, Show Well Done
Successfully handles: New, Create Well Done
Successfully handles: Edit, Update Well done
Successfully handles: Destroy, Task Complete ❗️ Destroy reroutes to task show, which errors. When the task gets destroyed, if a task no longer exists, should it direct to it's show page? - ❗️Don't see a specific route or controller action for completing a task
Routes follow RESTful conventions Well Done - Don't forget to set a root path
Uses named routes (like _path) Well done
Overall
The database will not replace the id numbers of tasks that were deleted - this is intentional design but should not affect any features of this application to error. If this is referring to the error from deleting a task, see above. Otherwise see me about what error you're referring to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant