forked from AdaGold/video-store-api
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Queues - Danielle Birbal & Marisol Lopez - VideoStoreAPI #4
Open
marisol-lopez
wants to merge
33
commits into
Ada-C7:master
Choose a base branch
from
marisol-lopez:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…customer name and postal code
… if there are no customers with overdue items
Video StoreWhat We're Looking For
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Video Store API
Congratulations! You're submitting your assignment!
If you didn't get to the functionality the question is asking about, reply with what you would have done if you had completed it.
Comprehension Questions
|
| List all the completed endpoints of your application. |
get '/customers', to: 'customers#index', as: 'customers'
get '/movies', to: 'movies#index', as: 'movies'
get '/movies/:title', to: 'movies#show', as: 'movie'
get '/rentals/overdue', to: 'customers#overdue', as: 'overdue'
post '/rentals/:title/check-out', to: 'movies#checkout', as: 'checkout'
post '/rentals/:title/check-in', to: 'movies#checkin', as: 'checkin'
|
| Describe a set of positive and negative test cases you implemented for a model. |
We mostly did associations and validations testing for the model, but we did do a test to make sure that an inventory of less than 0 could not be implemented.
|
| Describe a set of positive and negative test cases you implemented for a controller. |
We did a test case in the movies controller to check to make sure that the path for movies was valid and it would go to the correct controller action. As for a negative test case, we implemented a 404 test case for anyone trying to search for a title that did not exist.
|
| How does your API respond when bad data is sent to it? |
When certain bad data is sent you will either get an error message, a bad request HTTP code, or even an empty array.
|
| Describe one of your custom model methods and why you chose to wrap that functionality into a method. |
We didn't utilize any custom model methods.
|
| Do you have any recommendations on how we could improve this project for the next cohort? |
Clarify that the movies_checked_out_count and the available_inventory does not need to be apart of the table, because we did not realize that, and heard that was only clarified when specifically asking an instructor. Although, we were able to figure it out, it would've been way easier, to have written a method, because it did cause a lot of trouble when trying to complete that part of the assignment, especially with our database.
|
| Link to Trello | https://trello.com/b/BepwXIXV/videostoreapi |
| Link to ERD | https://www.lucidchart.com/invitations/accept/0f78b53b-e5b1-4bb3-bb2f-9cda3c9dd569 |
***Checked smoke tests for required and optional and all were fine.