Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queues - Janice Lichtman - api-muncher #51

Open
wants to merge 48 commits into
base: master
Choose a base branch
from
Open

Conversation

J-C-L
Copy link

@J-C-L J-C-L commented May 9, 2017

API Muncher

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
How did you go about exploring the Edamam API, how did you try querying the API? I read the documentation on the Edamam API site. Then I tried out searches with different parameters using Postman
Describe your API Wrapper. How did you decide on the methods you created? My api wrapper functions a bit like a model for a database, in that it handles my apps interaction with the Edamam API. The methods I needed are similar to database queries, and include a search method to find a list of recipes and a getRecipe method to retrieve a specific recipe.
Describe an edge case or failure case test you wrote for your API Wrapper. I tested that when no recipes were found for a given search term, my method returns an empty array.
Explain how VCR aids in testing an API. VCR saves the response to a call to the Edamam API (for a given query) in a cassette. Using the saved response, we can then test our internal methods and functionality without relying on the actual Edamam API. This is beneficial because testing our site does not cost us API calls, and our tests are unaffected by any external problems with the API itself.
What is the Heroku URL of your deployed application? https://recipe-requiem.herokuapp.com/

|
| Do you have any recommendations on how we could improve this project for the next cohort? |
|

J-C-L added 30 commits May 2, 2017 12:16
@PilgrimMemoirs
Copy link

API Muncher

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Well done
Comprehension questions Well Done
General
Rails fundamentals (RESTful routing, use of named paths) Well Done
Semantic HTML Mostly good - Only application.html.erb needs a body tag, other files don't since it loads within 'yield' tag of that file. Repeated elements, like the flash, should be in the application.html.erb.
Errors are reported to the user Well Done
API Wrapper to handle the API requests Well Done
Controller testing Well Done
Styling
Foundation Styling for responsive layout Well Done
Search View Well Done
List View Well done
Show View which opens in a new tab Well Done - suggestion: with this layout, have the content in the middle, with white space on the sides, for larger screen sizes
API Features
The App attributes Edaman Well done
The VCR casettes do not contain the API key Well Done
Overall
Great work implementing all the required tasks to expectations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants