Queues - Erica Case - API-Muncher

[EricaJCasePhD]

API Muncher

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
How did you go about exploring the Edamam API, how did you try querying the API?	I first went to the documentation on the developer site and read through the categories. I then tried querying through postman and finally through my own code
Describe your API Wrapper. How did you decide on the methods you created?	I ended up making a subclass fo
Describe an edge case or failure case test you wrote for your API Wrapper.	I made sure I got an empty array if a search returned no results.
Explain how VCR aids in testing an API.	It "records" the response for a given API call so that you do not have to call the website every time you test.
What is the Heroku URL of your deployed application?	https://eat-eat-eat.herokuapp.com/
Do you have any recommendations on how we could improve this project for the next cohort?	put whether you want us to use the gem for pagination. I spent a really long time trying to do it without the gem because I didn't know it would be so hard.

[EricaJCasePhD]

You have to click the photos to link.

[PilgrimMemoirs]

API Muncher

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	well Done
Comprehension questions	Mostly Good - 2nd question is incomplete
General
Rails fundamentals (RESTful routing, use of named paths)	Well Done
Semantic HTML	❗️ very little - content should be organized with semantic sectioning tags.
Errors are reported to the user	❗️ Did no do or approach - should show error if nothing is found from search or if uri of recipe for show is invalid. How could you handle doing so in your controller methods and application.html.erb?
API Wrapper to handle the API requests	Mostly good -If splitting functionality between two classes, does recipe need to inherit from api wrapper? The two search methods should belong to the same class.
Controller testing	❗️ None
Styling
Foundation Styling for responsive layout	very little - only for index list.
Search View	Mostly good - Should use foundation grid to organize content.
List View	Well Done
Show View which opens in a new tab	❗️ Did not do or approach
API Features
The App attributes Edaman	❗️ Did not do or approach
The VCR casettes do not contain the API key	Not there, but apparently works? - I remember you mentioning it was working without, but I still suggest having the full url w/ id and key just in case it was a fluke in the api and it changes later.
Overall
	I have a lot of concern over many requirements that were left out. Ex: giving attribution to edamam, error handling, controller tests, few tests for wrapper, linking to a recipe from show, etc.