Queues - Allison Northrop - API Muncher

[Allison-Northrop]

API Muncher

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
How did you go about exploring the Edamam API, how did you try querying the API?	I looked over the API documentation and then used postman to see what a query looks like/how it works. In particular I wanted to find out how to filter everything through a gluten free filter, so I looked on the documentation to find out what to put in the url.
Describe your API Wrapper. How did you decide on the methods you created?	I ended using the API wrapper as a way to make Recipe objects with the API JSON data. I created an initialize method with the data points I wanted within a recipe. I then created two self methods - one to search all recipes and one to chop up the uri to obtain the "id" of each individual recipe.
Describe an edge case or failure case test you wrote for your API Wrapper.	I tested if there was a search that didn't have any matching recipes, and i tested if there was a nil search.
Explain how VCR aids in testing an API.	VCR is a way of "taping" an API call so that every time a test is run, it doesn't have to call to the API (which can get expensive)
What is the Heroku URL of your deployed application?	https://gluten-freedom.herokuapp.com/
Do you have any recommendations on how we could improve this project for the next cohort?	I really liked this project, I thought it was the appropriate amount of work. Having said that, maybe some input on how to do pagination. ***I wrote code for pagination in the "pagination" branch, but still was unable to get it to work. If you could provide feedback on why it's not working, that would be awesome! I think I'm missing just one thing or something. I added code in the lib file, the controller and the views.

[PilgrimMemoirs]

API Muncher

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Mostly good - commit messages could be more specific (ex: 'added css stuff', 'fixed the weird end issue') Imagine if someone were to work on this and didn't have the context you did of having worked on this.
Comprehension questions	Well done
General
Rails fundamentals (RESTful routing, use of named paths)	Well Done
Semantic HTML	❗️ Okay - Any file that isn't application.html.erb does not need the head or body tags, because of that yield that is in application.html.erb, any of the other html.erb files you create will be rendered in there. search.html.erb is missing the opening li tag in the recipes loop. Be mindful of indentation (show_recipe is hard to read). show_recipe should be utilizing more semantic HTML 5 tags instead of 's, some elements are not wrappped in a sectioning tag.
Errors are reported to the user	Does not display anything if no recipes are found
API Wrapper to handle the API requests	Well Done
Controller testing	❗️ No Controller tests
Styling
Foundation Styling for responsive layout	❗️ Little - The foundation grid is not being utilized as much as it should be, particularly with the recipe list and show pages.
Search View	Well Done
List View	Mostly Good - It's hard to scroll through and see all my options on a page by having each recipe stack on top of the other. The list view is a great opportunity to use Foundation's block grid to more easily have the results display many in a row.
Show View which opens in a new tab	Well Done
API Features
The App attributes Edaman	Well Done
The VCR casettes do not contain the API key	Well Done
Overall
	Heroku not working.
	Nice work with creating the wrapper and setting up the routes and controller methods to interact with taking in user input to call the api through the wrapper. Definitely a challenge you executed to expectations!
	The front-end is lacking attention. Some areas for improvement would be to clean up your HTML code, right now it is very hard to read and lacks semantic html tags. Foundation also needs to be implemented more extensively with the show and view pages (the block grid is a lifesaver for lists!).
	You have a good start with the lib tests, however all the controller tests are missing.
	I don't see a pagination branch, it looks like you need to push the branch to github. Ping me on slack if you do that and want further feedback