Queues - Kayla Kubicke - API-Muncher #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated recipe test to utilize let to make test objects. Changed recipe attributes to conform to project. Cleaned up redundant code in test.
Added test to evaluate unsuccessful search term result. Added logic and message for redirect if unsuccessful search term is entered.
Search tests
…t of site. Show page displays name, list of ingredients, and link to original page. Library and controller pass along parameters and create variables correctly for show page. Updated concept of site and added easter egg.
show-recipe
Removed incorrect attribute tests. Added edge cases for both methods.
A valid uri returns a recipe show page and an invalid one redirects. Empty search term redirects to root page.
…d root_path redirects in controller tests.
Previous next
Foundation 2
Decided to go more towards a sarcastic 70's hair ad vibe.
API MuncherWhat We're Looking For
Good work overall! Make sure to check out the inline comments - mostly small style things that don't fit up here. |
| </head> | ||
| <div class='row'> | ||
| <div class="style1" align='center' height='35'> | ||
|
|
There was a problem hiding this comment.
All this stuff should be nested inside the <body> tag.
| @@ -0,0 +1,16 @@ | |||
| <div class='row nav'> | |||
There was a problem hiding this comment.
I like that you've moved this code into a partial.
| </div> <!-- These logic is here to keep the spacing in the page correct. --> | ||
| <% else %> | ||
| <div class='small-4 column' id='left-nav'> | ||
| <%= link_to "Previous Recipes", recipes_path(:utf8 => params[:utf8], :search => params[:search], :page => (params[:page].to_i - 1), :commit => params[:commit]) %> |
There was a problem hiding this comment.
While this code is certainly functional, it's also a little clunky. Is there any way you could use a helper method here to clean it up?
lib/recipe.rb
Outdated
| recipe_components[:ingredients] = response[0]['ingredientLines'] | ||
| recipe_components[:diet] = response[0]['dietLabels'] | ||
|
|
||
| return recipe_components |
There was a problem hiding this comment.
It's interesting to me that above you return Recipe objects, but here you return a hash. Seems to me you could add a little bit of functionality to Recipe and be able to reuse it nicely.
lib/recipe.rb
Outdated
| end | ||
|
|
||
| def self.show_recipe(uri) | ||
| url = "https://api.edamam.com/search?app_key=#{ENV['APP_KEY']}&app_id=#{ENV['APP_ID']}&r=http://www.edamam.com/ontologies/edamam.owl%23#{uri[1..-1]}" |
There was a problem hiding this comment.
Both the base URL and the ontologies URL would be good candidates for class constants here.
added 2 commits
May 10, 2017 12:35
Worked with Charles to DRY up Recipe Model and made method that exclusively creates Recipe objects. Adjusted tests to pass after the above changes, added tests for new method. Addressed most html comments, except navigation helper method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API Muncher
Congratulations! You're submitting your assignment!
Comprehension Questions
I figured out a way to create page link navigation (i.e. Page 1, Page 2, etc.) without any empty pages. The response['count'] the API returns is always incorrect, it returns many blank recipes so it is an unreliable number to create links with. But, if you send a second request with the response['count'] as the last requested index, you receive a value in the next response called 'to' which returns the actual number of valid recipes. If you send both responses in tandem you can create page navigation without any empty page numbers. It's very slow but it does solve the problem of empty page links. This solution is on my 'pagination' branch.