Queues - Marisol Lopez - API Muncher

[marisol-lopez]

API Muncher

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
How did you go about exploring the Edamam API, how did you try querying the API?
Describe your API Wrapper. How did you decide on the methods you created?
Describe an edge case or failure case test you wrote for your API Wrapper.
Explain how VCR aids in testing an API.
What is the Heroku URL of your deployed application?
Do you have any recommendations on how we could improve this project for the next cohort?

[droberts-sea]

API Muncher

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	yes
Comprehension questions	no :(
General
Rails fundamentals (RESTful routing, use of named paths)	yes
Semantic HTML	needs improvement - I see lots of <div>s, many of which could probably be something more semantic like <section> or <article>. Also, in application.html.erb your page should be organized into <header>, <main> and <footer> sections.
Errors are reported to the user	no - This should be one of the first things you do when you set up a new project (for example by adding code to display flash messages to application.html.erb). It will save you a lot of trouble in the long run.
API Wrapper to handle the API requests	yes - see inline comment
Controller testing	some - positive cases are well covered. Questions I would like to see your tests asking: "what happens if my search term returns 0 results?", "what happens if I try to show a recipe that doesn't exist?"
Styling
Foundation Styling for responsive layout	yes
Search View	yes
List View	yes
Show View which opens in a new tab	yes
API Features
The App attributes Edaman	no - This is one of the conditions for using their API! You should have some their logo in your site's footer, as well as something like "Powered by Edamam".
The VCR casettes do not contain the API key	yes
Overall

Good work overall!