Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS' JS Scrabble #19

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

JS' JS Scrabble #19

wants to merge 4 commits into from

Conversation

jjousun
Copy link

@jjousun jjousun commented May 18, 2017

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? The logic when thinking out the problems are transferrable. So things like running through conditional statements, looping through a collection or calling a function (method) were similar enough. I also used the same data structure, as in the Ruby version of the project, to store scoreboard information.
What was a challenge you were able to overcome on this assignment? Getting the syntax of JavaScript was challenging, especially invoking functions, which I learned needs parens to differentiate it from calling properties of an object. I also had a hard time wrapping my head around the structure of this project, as we've stored different objects in one file - I wasn't sure what the best practice for referencing functions of different objects in other objects was.
What is your favorite thing about learning a new programming language? I like surprising myself when I know more than I think I know. It took me a long time to make headway on Wave 1 of this project because I was doubting my abilities and kept putting it off. But when I pushed myself to do it anyway, I was able to get it done (with help!).
What is your least favorite thing about learning a new programming language? I'm worried that I'm too dim; it's difficult not to compare to others. I have massive anxiety that I'm not keeping up.
Do you have any recommendations on how we could improve this project for the next cohort? No, I think this was quite nice in that we got to revisit an old project (I like the opportunity to review my old work). It was a good level of challenge for the start of learning JS.

},

hasWon: function() {
if(this.totalScore() > 100) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could also be written,

return this.totalScore() > 100;

leaving out the if.

@CheezItMan
Copy link

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Check, Believe it or not being scared because you're NOT doing TDD is a GOOD sign!
Comprehension questions Don't worry about being dim. You're in no danger of that. Best way to see is to jump in.
General
score calculates score, has appropriate params and return value Check, name is a little different, no problem.
highestScoreFrom calculates highest scoring word, has appropriate params and return value Check
Player object
Has name and plays properties Check
Has play, totalScore, hasWon functions Check
Has highestScoringWord and highestWordScore functions Check
Overall Nicely done, direct and good use of Scrabble objects as hashes. I like how you used console.log for testing. It' a good practice if you don't have a testing dsm available. You probably don't need to use prototype in Scrabble since you'll only ever have one instance of it, but otherwise this is an excellent job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants