Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alena's JS Scrabble #24

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Conversation

Spatterjaaay
Copy link

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? Conditions were similar, also instance method logic was very similar too. In the end, I have also mirrored what was Ruby class method and instance method in my use of prototype function (I used prototype only for the instance methods and 'class' methods became attributes of the object).
What was a challenge you were able to overcome on this assignment? I think I gained a better understanding of what a prototype is. Before it wasn't entirely clear to me it should be used mostly for instance functions.
What is your favorite thing about learning a new programming language? I really enjoy discovering what are the differences between Ruby and JavaScript, and what new options in syntax and functionality are available in JS :)
What is your least favorite thing about learning a new programming language? Remembering the little details without which the code breaks, such as semicolons. Thank goodness for linter :)
Do you have any recommendations on how we could improve this project for the next cohort? I really enjoyed rewriting a familiar project in JS, I like it as it is. It's also nice to see how much faster we can do it, even if we are working with a whole new language.

@kariabancroft
Copy link

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Good
Comprehension questions Yes
General
score calculates score, has appropriate params and return value Good - note you want += not =+ usually
highestScoreFrom calculates highest scoring word, has appropriate params and return value Nice job making both of these "class-like" functions rather than "instance-like" functions
Player object
Has name and plays properties Yes
Has play, totalScore, hasWon functions Yes - nice use of the ternary
Has highestScoringWord and highestWordScore functions Good
Overall Nice job hitting the major learning goals of this assignment as well as exploring some of the optionals!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants