Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queues - Hyunji Kim - js-scrabble #25

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ricecakemonster
Copy link

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? Ruby's instance methods are like JavaScript's prototypes. It was easy to understand how prototypes should be coded.
What was a challenge you were able to overcome on this assignment? To get used to JS syntax.
Super confusing!
What is your favorite thing about learning a new programming language? So much easier than learning the first programming language, Ruby!
What is your least favorite thing about learning a new programming language? I kept on forgetting to add ";". Learning new language is confusing...
Do you have any recommendations on how we could improve this project for the next cohort? Maybe more explanation(lectures)?

@droberts-sea
Copy link

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene yes
Comprehension questions yes
General
score calculates score, has appropriate params and return value yes
highestScoreFrom calculates highest scoring word, has appropriate params and return value yes
Player object
Has name and plays properties Right now, you've got your played words as a global array, outside of Player. This means that if you have multiple Players, they'll both play words into the same array. Instead, you should have the array be a property of the Player.
Has play, totalScore, hasWon functions yes
Has highestScoringWord and highestWordScore functions yes
Overall

Great work overall!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants