Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sai's scrabble #32

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

sai's scrabble #32

wants to merge 4 commits into from

Conversation

ssamant
Copy link

@ssamant ssamant commented May 18, 2017

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? using conditionals; thinking about how objects relate to one another (e.g. passing player objects to the game
What was a challenge you were able to overcome on this assignment? slightly better understanding of protoypes
What is your favorite thing about learning a new programming language? hmmm, not sure yet.
What is your least favorite thing about learning a new programming language? wanting to do things the ruby way and not being able to
Do you have any recommendations on how we could improve this project for the next cohort? more scaffolding around working with different objects in relationship with each other

@CheezItMan
Copy link

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene I see you had commitment issues here. Understandable.
Comprehension questions Check, thank for the feedback
General
score calculates score, has appropriate params and return value Why Number(total)? Isn't it already a number?
highestScoreFrom calculates highest scoring word, has appropriate params and return value Interesting how it returns an array of 2 elements.
Player object
Has name and plays properties Check
Has play, totalScore, hasWon functions Check
Has highestScoringWord and highestWordScore functions Check, good use of the aforementioned array.
Overall Nice work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants