Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To submit #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

To submit #38

wants to merge 1 commit into from

Conversation

amb54
Copy link

@amb54 amb54 commented May 18, 2017

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? I could use many of the patterns, most of them.
What was a challenge you were able to overcome on this assignment? The module.export (but it was not that hard)
What is your favorite thing about learning a new programming language? It is fun to see the similarities and differences between the languages.
What is your least favorite thing about learning a new programming language? ?
Do you have any recommendations on how we could improve this project for the next cohort? It was good to compare with the Ruby Scrabble project.

@droberts-sea
Copy link

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene you've only got one commit, and the message isn't very descriptive. Please try to be better about this in the future, even on small projects.
Comprehension questions yes
General
score calculates score, has appropriate params and return value yes
highestScoreFrom calculates highest scoring word, has appropriate params and return value yes
Player object
Has name and plays properties yes
Has play, totalScore, hasWon functions yes
Has highestScoringWord and highestWordScore functions yes
Overall

Great work overall!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants