Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queues - Sahana Murthy - Scrabble JS #39

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

sahanamurthy
Copy link

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? Functionally, loops and conditionals work in essentially the same way. Prototype functions are similar to Ruby methods, and JS Object functions are similar to Ruby classes.
What was a challenge you were able to overcome on this assignment? Thinking through all the complex logic. In the Ruby assignment, we knew of different Ruby functions and enumerables, and we were able to use those to help us with complex logic. Using nothing but conditionals and loops was laborious.
What is your favorite thing about learning a new programming language? Seeing how easily I can pick up the syntax. It's great to be able to apply the same logic and learn it a bit quicker than my first programming language.
What is your least favorite thing about learning a new programming language? Finding out that it doesn't have certain functionality as other programming languages. I now understand why people use different languages depending on what they are trying to accomplish - "we use what's best for the job" - never understood that before.
Do you have any recommendations on how we could improve this project for the next cohort? Just forewarn C8 that the lack of Ruby magic will make this more complex than the original project.

@PilgrimMemoirs
Copy link

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Okay - should have more commit where the message is about what functionality was worked on.
Comprehension questions Well done - thanks for the feedback and perspective!
General
score calculates score, has appropriate params and return value Mostly Good - Should scoreChart be defined in the score function? By having it there it will be made every time that function is called. Instead, it's better to define it once as a property of Scrabble, then refer to that same object.
highestScoreFrom calculates highest scoring word, has appropriate params and return value Well Done - if your function starts handling a lot of logic and gets long like this, split it into multiple functions (much like what we did in ruby).
Player object
Has name and plays properties Well Done
Has play, totalScore, hasWon functions Well Done
Has highestScoringWord and highestWordScore functions Well Done - looks like highest scoring word is returning in an array, should just be the string.
Overall
Overall this project meets expectations. Nice work creating the required functionality and have the objects interact with each other. My suggestions are to revisit the highestScoringWord and organize the logic and to be mindful of how/where you declare variables - utilize the object's properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants