Alison's Ride Share

[AlisonZ]

Ride Share

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a design decision you had to make when working on this project. What options were you considering? What helped you make your final decision?	A major design decision was how to have the pieces talk to each other and where to handle the "heavy lifting"(??) I chose for the driver and rider class to mostly call other methods in the Trip class and the Trip class did most of the work.
Describe a concept that you gained more clarity on as you worked on this assignment.	Class methods vs. instance methods!!!!!!!!
Describe a nominal test that you wrote for this assignment.	In testing the find all trips method I tested that driver 16 returned all 6 trips that were listed for that driver in the data file.
Describe an edge case test that you wrote for this assignment.	I tested a driver that didn't exist in the data file returned an argument error warning of invalid driver.
How do you feel you did in writing pseudocode first, then writing the tests and then the code?	I love pseudocode and don't understand how anyone codes without doing it. And I am becoming a huge fan of writing tests first then code. I find my code is so much clearer by the time I get to writing it.

[CheezItMan]

Just a few comments

[CheezItMan]

Since you're not testing all elements here, I would either make a loop that tests them all or at least change the title here.

[CheezItMan]

I would suggest that here, you should just return nil if they try to find a Driver that doesn't exist.

[CheezItMan]

Should be tabbed over!

[CheezItMan]

Ride Share

What We're Looking For

Feature	Feedback
Baseline
Used Git Regularly	I think you should be breaking up things into more "atomic" commits. You've got a lot in the commits I saw.
Answer comprehension questions	Nice thinking with the Trip class. It's good to hear your growing confidence with pseudo-code & testing!
Driver
Uses the all method in the find method	Check, but could you use the .find enumerable method instead of .each
Has appropriate edge-case tests for each method in the class	Well done
Created a method that uses a method from the Trip object to retrieve the list of trips	Check
Created a method that uses the internal trips list to calculate the average rating	Check
Rider
Uses the all method in the find method	Check, although you could use a different than enumerable to find a Rider.
Has appropriate edge-case tests for each method in the class	Check
Created a method that uses a method from the Trip object to retrieve the list of trips	Check
Created a method that uses the internal trips method to retrieve the associated drivers	Check
Trip
Reads the CSV file in the all method	Well done
Has appropriate edge-case tests for each method in the class	What about tests for Trip.find?
Created a method that uses a method from the Driver to retrieve the associated driver instance	Check
Created a method that uses a method from the Rider to retrieve the associated rider instance	Check
Created a method to retrieve all trips by driver id	Check
Created a method to retrieve all trips by rider id	Check

Summary

Nicely done, it does seem like you missed a test for Trip.find, but you've shown a lot of growth here. Another question, are there requirements on IDs? Do they have to be positive Integers?

[CheezItMan]

You should also make sure it's the correct drivers.