Anacelia's Ride Share

[acgillette]

Ride Share

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a design decision you had to make when working on this project. What options were you considering? What helped you make your final decision?	One decision I had to make was whether or not to make module it's own file or to implement it in each class file. However when I implemented it in each class file I kept getting circular reasoning warnings due to my require_relative's, so I decided it would be best to keep it in its own file.
Describe a concept that you gained more clarity on as you worked on this assignment.	One concept I gained clarity on was choosing when to use an ArgumentError and when to simply return nil, based on what I thought would work best for the program. At first I had it return an argument error when a driver or rider was not found but realized it would work better to just have it return nil.
Describe a nominal test that you wrote for this assignment.	Testing that driver.trips returned an array of driver objects.
Describe an edge case test that you wrote for this assignment.	Testing that driver.trips returned nil if no drivers for a given trip were found.
How do you feel you did in writing pseudocode first, then writing the tests and then the code?	I think it helped a lot, especially since my tendency is to dive right into coding. By making myself first draw out a diagram and think about my testing it helped mitigate design problems I might have had if I'd simply dived right in without thinking of these things first, and it helped me understand what to do when I had a diagram to refer back to.

[CheezItMan]

Ride Share

What We're Looking For

Feature	Feedback
Baseline
Used Git Regularly	Check, but you don't need to commit coverage, best to have it included in .gitignore
Answer comprehension questions	Well done
Driver
Uses the all method in the find method	Check
Has appropriate edge-case tests for each method in the class	Check, good use of let
Created a method that uses a method from the Trip object to retrieve the list of trips	Check and good use of Enumerable
Created a method that uses the internal trips list to calculate the average rating	Check
Rider
Uses the all method in the find method	check
Has appropriate edge-case tests for each method in the class	You should test more than just the first element in .all you should also test the last element.
Created a method that uses a method from the Trip object to retrieve the list of trips	Check
Created a method that uses the internal trips method to retrieve the associated drivers	Check
Trip
Reads the CSV file in the all method	Check
Has appropriate edge-case tests for each method in the class	Similar to the previous classes you didn't test the edges of .all. You also didn't test for invalid ratings!
Created a method that uses a method from the Driver to retrieve the associated driver instance	Check
Created a method that uses a method from the Rider to retrieve the associated rider instance	Check
Created a method to retrieve all trips by driver id	Check
Created a method to retrieve all trips by rider id	Check

Summary

Nicely done, you made great use of Enumerables and write fairly DRY code. You also made good use of let in your testing. You do need to be more through in your testing however.