Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queues - Sahana Murthy - Ride Share 2 #24

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

sahanamurthy
Copy link

Ride Share

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe a design decision you had to make when working on this project. What options were you considering? What helped you make your final decision? One design decision that I had to make was regarding the code in the Driver class Rating method. I had two different ways of approaching the requirement of the method. One way has more readability but is a longer code. The other is a shorter code but has less readability. I opted for the shorter code with less readability, as I thought it looked more elegant. I also added a comment that explained what the method does, therefore helping with the readability issue.
Describe a concept that you gained more clarity on as you worked on this assignment. I learned more about how to parse data from csv files. I also learned more about enumerables!
Describe a nominal test that you wrote for this assignment. A nominal test that I wrote was testing that a Driver instance could be created with a driver id of 1.
Describe an edge case test that you wrote for this assignment. An edge case test that I wrote was testing that a Driver instance couldn't be created with a string driver id.
How do you feel you did in writing pseudocode first, then writing the tests and then the code? I wrote my pseudocode on paper, and I believe that helped me significantly. It allowed me to organize and outline my thoughts.

@PilgrimMemoirs
Copy link

Ride Share

What We're Looking For

Feature Feedback
Baseline
Used Git Regularly Mostly good - could have some more commits with more specific messages
Answer comprehension questions Well Done
Driver
Uses the all method in the find method Well Done
Has appropriate edge-case tests for each method in the class Mostly good
Created a method that uses a method from the Trip object to retrieve the list of trips Well Done
Created a method that uses the internal trips list to calculate the average rating Well Done
Rider
Uses the all method in the find method Well Done
Has appropriate edge-case tests for each method in the class Mostly Good
Created a method that uses a method from the Trip object to retrieve the list of trips Well Done
Created a method that uses the internal trips method to retrieve the associated drivers Well Done
Trip
Reads the CSV file in the all method
Has appropriate edge-case tests for each method in the class Well done
Created a method that uses a method from the Driver to retrieve the associated driver instance Well Done
Created a method that uses a method from the Rider to retrieve the associated rider instance Well Done
Created a method to retrieve all trips by driver id Well Done
Created a method to retrieve all trips by rider id Well Done
Overall
Looks great! Could use more edge case tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants