Haby's RideShare

[habypsow]

Ride Share

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a design decision you had to make when working on this project. What options were you considering? What helped you make your final decision?	Thinking big picture, as to how all some classes 's methods would be utilized in different classes was something I had not done before. Having the Farmar diagrams discussion in class helped me see what classes/method connections would be important to have, in the RideShare module. I wrote pseudocode before starting to write code, and tackled each prompt step by step.
Describe a concept that you gained more clarity on as you worked on this assignment.	This assignment helped solidify my understanding on how classes and their associated methods can be utilized in different classes.
Describe a nominal test that you wrote for this assignment.	When calling a method to find all drivers, to check that the drivers' length is 100, for example.
Describe an edge case test that you wrote for this assignment.	Testing for cases that were not included in the CSV file, for example an instance where the driver_id does not exist
How do you feel you did in writing pseudocode first, then writing the tests and then the code?	I feel it kept me on track, completing the assignment step by step helped keep my thoughts concise, and I knew what next steps were needed as well. I find pseudocode really helpful.

[CheezItMan]

Ride Share

What We're Looking For

Feature	Feedback
Baseline
Used Git Regularly	You're not making many commits. It would be better to try commiting after finishing a method or tests on a method.
Answer comprehension questions	I'm glad you've found pseudo-code useful and that you are more comfortable calling methods in other classes.
Driver
Uses the all method in the find method	Check
Has appropriate edge-case tests for each method in the class	Good use of let and good checking the number of entries returned from the CSV
Created a method that uses a method from the Trip object to retrieve the list of trips	Check
Created a method that uses the internal trips list to calculate the average rating	Check & good use of Enumerable
Rider
Uses the all method in the find method	Check
Has appropriate edge-case tests for each method in the class	Good, and you're checking the 1st and last entries in the file
Created a method that uses a method from the Trip object to retrieve the list of trips	Check
Created a method that uses the internal trips method to retrieve the associated drivers	Check
Trip
Reads the CSV file in the all method	Check
Has appropriate edge-case tests for each method in the class	Check, good naming conventions on the let variables as well
Created a method that uses a method from the Driver to retrieve the associated driver instance	Check
Created a method that uses a method from the Rider to retrieve the associated rider instance	Check
Created a method to retrieve all trips by driver id	Check
Created a method to retrieve all trips by rider id	Check

Summary

Very well done. This is good work, you've had a lot of growth here. Time for Rails!