Queues - Tamiko Terada - ride-share-two

[TamikoT]

Ride Share

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a design decision you had to make when working on this project. What options were you considering? What helped you make your final decision?	I decided that it was okay that there were so many dependencies between the three classes because you would have a Rider and Driver for every Trip instance.
Describe a concept that you gained more clarity on as you worked on this assignment.	I gained more clarity on why you would want to create custom exceptions for things because you don't want to do blanket rescues. I also have a better understanding of how drawing a diagram can help with thinking about relationships.
Describe a nominal test that you wrote for this assignment.	I made sure that .all was creating an array of instances for each of the three classes.
Describe an edge case test that you wrote for this assignment.	In driver_spec I wrote some edge case tests for a bad or missing vin with the expectation of String messages.
How do you feel you did in writing pseudocode first, then writing the tests and then the code?	I think that it was very helpful to use UML and pseudocode to write the tests first and then the methods but then I ran into the problem of not having thought of exceptions in the design and having to add both tests and lines in existing methods which proved to be very inefficient. If I was tackling a similar problem, I would definitely incorporate exception design and thinking about what is the best datatype for the various variables all in the initial planning instead of trying to figure it out after I have working methods.

[PilgrimMemoirs]

Ride Share

What We're Looking For

Feature	Feedback
Baseline
Used Git Regularly	Well Done
Answer comprehension questions	Well Done
Driver
Uses the all method in the find method	Well Done
Has appropriate edge-case tests for each method in the class	Well Done
Created a method that uses a method from the Trip object to retrieve the list of trips	Well Done
Created a method that uses the internal trips list to calculate the average rating	Well Done
Rider
Uses the all method in the find method	Well Done
Has appropriate edge-case tests for each method in the class	Some - methods could have more. like if given an incorrect input.
Created a method that uses a method from the Trip object to retrieve the list of trips	Well Done
Created a method that uses the internal trips method to retrieve the associated drivers	❗️ In past_drivers, instead of having "RideShare::Trip.by_rider(@id)", should call your past_trips method. how come?
Trip
Reads the CSV file in the all method	Well done - make sure to use path relative to the project "./support/trips.csv"
Has appropriate edge-case tests for each method in the class	Mostly good
Created a method that uses a method from the Driver to retrieve the associated driver instance	Well Done - could just be called 'driver'
Created a method that uses a method from the Rider to retrieve the associated rider instance	Well Done - same as box above
Created a method to retrieve all trips by driver id	Well Done
Created a method to retrieve all trips by rider id	Well Done
Overall