Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queues - Sofia Kim - trek #21

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Queues - Sofia Kim - trek #21

wants to merge 17 commits into from

Conversation

Sofia15
Copy link

@Sofia15 Sofia15 commented May 30, 2017

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? A process operates independently of other processes.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? I put the reservation form as the individual trip's view page is generated.
What kind of errors might the API give you? How did you choose to handle them? As the AJAX request failed, I made the code provide the error message.
What is an Underscore template? Describe one template you used for this project. It is a JavaScript library which provides utility functions for common programming tasks.
Do you have any recommendations on how we could improve this project for the next cohort?

@PilgrimMemoirs
Copy link

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Well Done
Comprehension questions Mostly Good - Be more specific on the underscore answer. How and why are we using underscore?
Functionality
Click a button to list trips Trips should not load on page until the button is clicked
Click a trip to see trip details Well Done
Fill out a form to reserve a spot Well Done
Errors are reported to the user Well Done - Though I would make the message more user friendly, most people don't know what Ajax is
Styling, Foundation grid layout ❗️ Did not use Foundation Grid.
Under the Hood
Trip data is retrieved using jQuery AJAX Well Done
JavaScript is well-organized and easy to read Well Done - Really nice work reusing functions and organizing code.
HTML is semantic Okay - should still be using sectioning tags like header. Not all content is wrapped in sectioning tags, like the error elements.
All dynamic content is rendered using Underscore templates Well Done - When templates are mixed in with the static HTML, it can be hard to read them as templates. It's better practice to have them all defined towards the bottom
Overall
Great work on all the required functionality. The submission meets expectations and learning goals for this project. Just remember to keep using best practices with HTML and CSS - like organizing content using Foundation's grid and wrapping all content in semantic sectioning tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants