Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bo's Trek! #22

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Bo's Trek! #22

wants to merge 8 commits into from

Conversation

botrethewey
Copy link

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? It means that the code is not executed in the order it appears in the file. Instead it happens the code runs upon some kind of event like a click or keydown.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? When the user clicks on the 'See Filters' button, the filters become visible on the page and the 'See Filter' button becomes hidden while the 'Hide Filter' button becomes visible in its place.
What kind of errors might the API give you? How did you choose to handle them? The API gave HTTP ERROR 500 when query calls were made with an invalid parameter for the filtered search. I used 'require' option on each input field of the form as well as setting some placeholder values to guide the user. Also depending on the error type, I alert the user that either there were no matches for their search, or the AJAX request has failed in more general case(wrong url, server down, wifi down etc.)
What is an Underscore template? Describe one template you used for this project. An underscore template allows us to generates html content using a data accessed within the JS file, without having to hardcode it directly into html. In this project I used an underscore template to populate the list of trip packages returned by the API call.
Do you have any recommendations on how we could improve this project for the next cohort? I thought this project was a nice exercise for getting comfortable with using underscore and jQuery. Also a nice refresher for working with API as well.

@CheezItMan
Copy link

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene You could make more granular commits.
Comprehension questions Check
Functionality
Click a button to list trips Check
Click a trip to see trip details Check
Fill out a form to reserve a spot Check
Errors are reported to the user Check
Styling, Foundation grid layout Good grid layout styling, but the listing page could probably do with a 2nd column of trips at large screen size.
Under the Hood
Trip data is retrieved using jQuery AJAX Check
JavaScript is well-organized and easy to read Check
HTML is semantic Check
All dynamic content is rendered using Underscore templates Check
Exras You have filtering by continent, cost and duration! nice work!
Overall Good work, you hit all the requirements and extras!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants